centersl/nextcloud-docs
1
0
Fork 0
mirror of https://github.com/nextcloud/documentation.git synced 2026-03-30 14:08:39 +07:00
Code Issues Packages Projects Releases Wiki Activity

Fixing Non-ASCII Characters

Browse Source
This commit is contained in:
WireShout
2012-12-13 14:48:44 -05:00
parent 3751ef5a65
commit b728403b72
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
developer_manual/codereviews.rst
View File

@@ -6,7 +6,7 @@ The test phase will ONLY apply for the `core repository`_ at the moment.
(Other repositories are welcome to join )
Let's see if we get any benefit from this approach.``
Linus’ Law: *“given enough eyeballs, all bugs are shallow”*
Linus' Law: *"given enough eyeballs, all bugs are shallow"*
Introduction
------------
@@ -18,12 +18,12 @@ Precondition
------------
From now on no direct commits/pushes to master or any of the stable branches are allowed in general.
**Every code** change – **even one liners** – have to be reviewed!
**Every code** change - **even one liners** - have to be reviewed!
How will it work?
-----------------
#. A developer will submit his changes on github via a pull request. `github:help – using pull requests`_
#. A developer will submit his changes on github via a pull request. `github:help - using pull requests`_
#. Within the pull request the developer could already name other developers (using @githubusername) and ask them for review.
#. Other developers (either named or at free will) have a look at the changes and are welcome to write comments within the comment field.
#. In case the reviewer is okay with the changes and thinks all his comments and suggestions have been take into account a :+1 on the comment will signal a positive review.
@@ -43,7 +43,7 @@ Questions?
Feel free to drop a line on the `mailing list`_ or join us on `IRC`_.
.. _core repository: https://github.com/owncloud/core
.. _github:help – using pull requests: https://help.github.com/articles/using-pull-requests
.. _github:help - using pull requests: https://help.github.com/articles/using-pull-requests
.. _continuous integration server: https://ci.tmit.eu/
.. _mailing list: https://mail.kde.org/mailman/listinfo/owncloud
.. _IRC: http://webchat.freenode.net/?channels=owncloud-dev
.. _IRC: http://webchat.freenode.net/?channels=owncloud-dev