From b728403b727df700e17a41ca4a5877fc52285dfb Mon Sep 17 00:00:00 2001 From: WireShout Date: Thu, 13 Dec 2012 14:48:44 -0500 Subject: [PATCH] Fixing Non-ASCII Characters --- developer_manual/codereviews.rst | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/developer_manual/codereviews.rst b/developer_manual/codereviews.rst index 8bf69a66e..83aa1c969 100644 --- a/developer_manual/codereviews.rst +++ b/developer_manual/codereviews.rst @@ -6,7 +6,7 @@ The test phase will ONLY apply for the `core repository`_ at the moment. (Other repositories are welcome to join ) Let's see if we get any benefit from this approach.`` -Linus’ Law: *“given enough eyeballs, all bugs are shallow”* +Linus' Law: *"given enough eyeballs, all bugs are shallow"* Introduction ------------ @@ -18,12 +18,12 @@ Precondition ------------ From now on no direct commits/pushes to master or any of the stable branches are allowed in general. -**Every code** change – **even one liners** – have to be reviewed! +**Every code** change - **even one liners** - have to be reviewed! How will it work? ----------------- -#. A developer will submit his changes on github via a pull request. `github:help – using pull requests`_ +#. A developer will submit his changes on github via a pull request. `github:help - using pull requests`_ #. Within the pull request the developer could already name other developers (using @githubusername) and ask them for review. #. Other developers (either named or at free will) have a look at the changes and are welcome to write comments within the comment field. #. In case the reviewer is okay with the changes and thinks all his comments and suggestions have been take into account a :+1 on the comment will signal a positive review. @@ -43,7 +43,7 @@ Questions? Feel free to drop a line on the `mailing list`_ or join us on `IRC`_. .. _core repository: https://github.com/owncloud/core -.. _github:help – using pull requests: https://help.github.com/articles/using-pull-requests +.. _github:help - using pull requests: https://help.github.com/articles/using-pull-requests .. _continuous integration server: https://ci.tmit.eu/ .. _mailing list: https://mail.kde.org/mailman/listinfo/owncloud -.. _IRC: http://webchat.freenode.net/?channels=owncloud-dev \ No newline at end of file +.. _IRC: http://webchat.freenode.net/?channels=owncloud-dev