Apply suggestions from code review

Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Christian Wolf <github@christianwolf.email>
This commit is contained in:
Christian Wolf
2024-10-04 00:04:53 +02:00
parent 6a9fb9d76e
commit 9b817ad141

View File

@@ -92,10 +92,10 @@ Both provide a way to transmit data between the backend of the app in the Nextcl
The following combinations of attributes might be useful for various scenarios:
#. Plain frontend route: No special attribute related to CSRF or CORS
#. Plain frontend route: ``Controller`` class
#. Plain Frontend with CRSF checks disabled: Add the ``#[NoCSRFRequired]`` attribute
#. REST route with CORS enabled: Add the ``#[CORS]`` attribute
#. OCS-based route
#. REST route with CORS enabled: ``Controller`` class and ``#[CORS]`` attribute on the route
#. OCS-based route: ``OCSController`` class
There are different ways a clients might interact with your APIs.
These ways depend on your API configuration (what you allow) and on which route the request is finally made.
@@ -134,13 +134,13 @@ These ways depend on your API configuration (what you allow) and on which route
- ---
- ---
- yes
- yes
- no
* - Transmitted data type
- plain data
- plain data
- plain data
- encapsulated data
- encapsulated data (JSON or XML)
As a rule of thumb one can conclude that OCS provides a good way to handle most use cases.
As a rule of thumb one can conclude that OCS provides a good way to handle most use cases including sufficient security checks.
The only exception to this is if you want to provide an API for external usage where you have to comply with an externally defined API scheme.
Here, the encapsulation introduced in OCS might be in your way.
Here, the encapsulation introduced in OCS and CSRF checks might be in your way.