centersl/lobehub
1
0
Fork 0
mirror of https://github.com/lobehub/lobehub.git synced 2026-03-26 13:19:34 +07:00
Code Issues Packages Projects Releases Wiki Activity

✅ test(desktop): fix menu accelerator tests to assert role instead of explicit accelerator

Browse Source 
Role-based menu items have their accelerators handled by Electron runtime, so tests should verify the role property rather than an explicit accelerator value.
This commit is contained in:
Innei
2026-02-09 15:50:09 +08:00
committed by arvinxx
parent eefb67e74a
commit 8493e20e5b
3 changed files with 32 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
apps/desktop/src/main/menus/impls/linux.test.ts
View File

@@ -299,47 +299,47 @@ describe('LinuxMenu', () => {
});
describe('menu accelerators', () => {
it('should use Ctrl prefix for Linux shortcuts', () => {
it('should use role for standard edit shortcuts (accelerators handled by Electron)', () => {
linuxMenu.buildAndSetAppMenu();
const template = (Menu.buildFromTemplate as any).mock.calls[0][0];
const editMenu = template.find((item: any) => item.label === 'Edit');
const copyItem = editMenu.submenu.find((item: any) => item.label === 'Copy');
expect(copyItem.accelerator).toBe('Ctrl+C');
expect(copyItem.role).toBe('copy');
});
it('should set correct accelerator for close', () => {
it('should use role for close (accelerator handled by Electron)', () => {
linuxMenu.buildAndSetAppMenu();
const template = (Menu.buildFromTemplate as any).mock.calls[0][0];
const fileMenu = template.find((item: any) => item.label === 'File');
const closeItem = fileMenu.submenu.find((item: any) => item.label === 'Close');
expect(closeItem.accelerator).toBe('Ctrl+W');
expect(closeItem.role).toBe('close');
});
it('should set correct accelerator for minimize', () => {
it('should use role for minimize (accelerator handled by Electron)', () => {
linuxMenu.buildAndSetAppMenu();
const template = (Menu.buildFromTemplate as any).mock.calls[0][0];
const fileMenu = template.find((item: any) => item.label === 'File');
const minimizeItem = fileMenu.submenu.find((item: any) => item.label === 'Minimize');
expect(minimizeItem.accelerator).toBe('Ctrl+M');
expect(minimizeItem.role).toBe('minimize');
});
it('should set Ctrl+Shift+Z for redo', () => {
it('should use role for redo (accelerator handled by Electron)', () => {
linuxMenu.buildAndSetAppMenu();
const template = (Menu.buildFromTemplate as any).mock.calls[0][0];
const editMenu = template.find((item: any) => item.label === 'Edit');
const redoItem = editMenu.submenu.find((item: any) => item.label === 'Redo');
expect(redoItem.accelerator).toBe('Ctrl+Shift+Z');
expect(redoItem.role).toBe('redo');
});
it('should set F11 for fullscreen', () => {
it('should use role for fullscreen (accelerator handled by Electron)', () => {
linuxMenu.buildAndSetAppMenu();
const template = (Menu.buildFromTemplate as any).mock.calls[0][0];
@@ -348,7 +348,7 @@ describe('LinuxMenu', () => {
(item: any) => item.label === 'Toggle Full Screen',
);
expect(fullscreenItem.accelerator).toBe('F11');
expect(fullscreenItem.role).toBe('togglefullscreen');
});
});
@@ -375,14 +375,14 @@ describe('LinuxMenu', () => {
expect(mockApp.browserManager.retrieveByIdentifier).toHaveBeenCalledWith('devtools');
});
it('should set Ctrl+Shift+I for developer tools', () => {
it('should use role for developer tools (accelerator handled by Electron)', () => {
linuxMenu.buildAndSetAppMenu({ showDevItems: true });
const template = (Menu.buildFromTemplate as any).mock.calls[0][0];
const devMenu = template.find((item: any) => item.label === 'Developer');
const devToolsItem = devMenu.submenu.find((item: any) => item.label === 'Developer Tools');
expect(devToolsItem.accelerator).toBe('Ctrl+Shift+I');
expect(devToolsItem.role).toBe('toggleDevTools');
});
it('should include reload options in developer menu', () => {
@@ -411,13 +411,14 @@ describe('LinuxMenu', () => {
expect(pasteItem).toBeDefined();
});
it('should use Ctrl accelerators in context menus', () => {
it('should use role for copy in context menus (accelerator handled by Electron)', () => {
linuxMenu.buildContextMenu('editor');
const template = (Menu.buildFromTemplate as any).mock.calls[0][0];
const copyItem = template.find((item: any) => item.role === 'copy');
expect(copyItem.accelerator).toBe('Ctrl+C');
expect(copyItem).toBeDefined();
expect(copyItem.role).toBe('copy');
});
it('should include cut in editor context menu', () => {
@@ -427,7 +428,7 @@ describe('LinuxMenu', () => {
const cutItem = template.find((item: any) => item.role === 'cut');
expect(cutItem).toBeDefined();
expect(cutItem.accelerator).toBe('Ctrl+X');
expect(cutItem.role).toBe('cut');
});
it('should include delete in editor context menu', () => {

8
apps/desktop/src/main/menus/impls/macOS.test.ts
View File

@@ -274,24 +274,24 @@ describe('MacOSMenu', () => {
expect(preferencesItem.accelerator).toBe('Command+,');
});
it('should set correct accelerator for quit', () => {
it('should use role for quit (accelerator handled by Electron)', () => {
macOSMenu.buildAndSetAppMenu();
const template = (Menu.buildFromTemplate as any).mock.calls[0][0];
const appMenu = template[0];
const quitItem = appMenu.submenu.find((item: any) => item.label === 'Quit');
expect(quitItem.accelerator).toBe('Command+Q');
expect(quitItem.role).toBe('quit');
});
it('should set correct accelerator for copy in edit menu', () => {
it('should use role for copy in edit menu (accelerator handled by Electron)', () => {
macOSMenu.buildAndSetAppMenu();
const template = (Menu.buildFromTemplate as any).mock.calls[0][0];
const editMenu = template.find((item: any) => item.label === 'Edit');
const copyItem = editMenu.submenu.find((item: any) => item.label === 'Copy');
expect(copyItem.accelerator).toBe('Command+C');
expect(copyItem.role).toBe('copy');
});
it('should set correct accelerators for history navigation', () => {

23
apps/desktop/src/main/menus/impls/windows.test.ts
View File

@@ -256,14 +256,14 @@ describe('WindowsMenu', () => {
});
describe('menu accelerators', () => {
it('should use Ctrl prefix for Windows shortcuts', () => {
it('should use role for standard edit shortcuts (accelerators handled by Electron)', () => {
windowsMenu.buildAndSetAppMenu();
const template = (Menu.buildFromTemplate as any).mock.calls[0][0];
const editMenu = template.find((item: any) => item.label === 'Edit');
const copyItem = editMenu.submenu.find((item: any) => item.label === 'Copy');
expect(copyItem.accelerator).toBe('Ctrl+C');
expect(copyItem.role).toBe('copy');
});
it('should set correct accelerator for close', () => {
@@ -276,24 +276,24 @@ describe('WindowsMenu', () => {
expect(closeItem.accelerator).toBe('Alt+F4');
});
it('should set correct accelerator for minimize', () => {
it('should use role for minimize (accelerator handled by Electron)', () => {
windowsMenu.buildAndSetAppMenu();
const template = (Menu.buildFromTemplate as any).mock.calls[0][0];
const fileMenu = template.find((item: any) => item.label === 'File');
const minimizeItem = fileMenu.submenu.find((item: any) => item.label === 'Minimize');
expect(minimizeItem.accelerator).toBe('Ctrl+M');
expect(minimizeItem.role).toBe('minimize');
});
it('should set F11 for fullscreen', () => {
it('should use role for fullscreen (accelerator handled by Electron)', () => {
windowsMenu.buildAndSetAppMenu();
const template = (Menu.buildFromTemplate as any).mock.calls[0][0];
const viewMenu = template.find((item: any) => item.label === 'View');
const fullscreenItem = viewMenu.submenu.find((item: any) => item.label === 'Full Screen');
expect(fullscreenItem.accelerator).toBe('F11');
expect(fullscreenItem.role).toBe('togglefullscreen');
});
});
@@ -320,14 +320,14 @@ describe('WindowsMenu', () => {
expect(mockApp.browserManager.retrieveByIdentifier).toHaveBeenCalledWith('devtools');
});
it('should set Ctrl+Shift+I for developer tools', () => {
it('should use role for developer tools (accelerator handled by Electron)', () => {
windowsMenu.buildAndSetAppMenu({ showDevItems: true });
const template = (Menu.buildFromTemplate as any).mock.calls[0][0];
const devMenu = template.find((item: any) => item.label === 'Developer');
const devToolsItem = devMenu.submenu.find((item: any) => item.label === 'Developer Tools');
expect(devToolsItem.accelerator).toBe('Ctrl+Shift+I');
expect(devToolsItem.role).toBe('toggleDevTools');
});
});
@@ -343,13 +343,14 @@ describe('WindowsMenu', () => {
expect(pasteItem).toBeDefined();
});
it('should use Ctrl accelerators in context menus', () => {
it('should use role for copy in context menus (accelerator handled by Electron)', () => {
windowsMenu.buildContextMenu('editor');
const template = (Menu.buildFromTemplate as any).mock.calls[0][0];
const copyItem = template.find((item: any) => item.role === 'copy');
expect(copyItem.accelerator).toBe('Ctrl+C');
expect(copyItem).toBeDefined();
expect(copyItem.role).toBe('copy');
});
it('should include cut in editor context menu', () => {
@@ -359,7 +360,7 @@ describe('WindowsMenu', () => {
const cutItem = template.find((item: any) => item.role === 'cut');
expect(cutItem).toBeDefined();
expect(cutItem.accelerator).toBe('Ctrl+X');
expect(cutItem.role).toBe('cut');
});
it('should include delete in editor context menu', () => {