Commit Graph

443 Commits

Author SHA1 Message Date
Diogo Monica
6f4e6fffea Fixing protobufs and signer
Signed-off-by: Diogo Monica <diogo@docker.com>
2015-07-22 16:51:55 -07:00
David Lawrence
81d69a4f5c update signature proto to include sig algorithm
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
2015-07-22 16:51:55 -07:00
Nathan McCauley
65916d3fc4 Merge pull request #117 from dmcgowan/add-remaining-passphrase-failure
Add missing use of invalid passphrase error
2015-07-22 16:14:25 -07:00
Diogo Mónica
f0912247ed Merge pull request #116 from dmcgowan/invalid-password
Return invalid password when cannot retrieve passphrase
2015-07-22 15:39:31 -07:00
Diogo Mónica
21a9b99e94 Merge pull request #114 from docker/invalid_password_err
better error handling for invalid password
2015-07-22 15:09:53 -07:00
Diogo Mónica
f6cf1f6e62 Merge pull request #115 from docker/updating_gotuf
updating gotuf dep with some better http error handling.
2015-07-22 13:38:39 -07:00
David Lawrence
1fc3257f6e updating gotuf dep with some better http error handling.
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
2015-07-22 13:19:52 -07:00
David Lawrence
cfe8255187 better error handling for invalid password
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
2015-07-22 11:37:54 -07:00
Derek McGowan
304afb53d0 Add missing use of invalid passphrase error
Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
2015-07-22 04:08:14 -07:00
Derek McGowan
5eb296d276 Return invalid password when cannot retrieve passphrase
Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
2015-07-22 03:42:16 -07:00
Nathan McCauley
eb52b64586 Merge pull request #110 from docker/test_fixing
Test fixing
2015-07-21 14:07:44 -07:00
David Lawrence
1f53e171bc updating vendored gotuf with updating signing error messages
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
2015-07-21 14:04:05 -07:00
David Lawrence
8b2888d122 latest vendored gotuf
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
2015-07-21 13:57:21 -07:00
Nathan McCauley
c6fc667114 Merge pull request #108 from docker/fixing-filestores
Fixed but with loadCertsFromDir and added tests
2015-07-20 21:39:02 -07:00
Diogo Mónica
5642ef7b78 Merge pull request #109 from docker/root_key_generation_warning
Root key generation warning
2015-07-20 20:35:33 -07:00
Nathan McCauley
a8b61c2f2b Root key generation warning, incorrect passphrase notification
Signed-off-by: Nathan McCauley <nathan.mccauley@docker.com>
2015-07-20 20:06:11 -07:00
Diogo Monica
b8b59dbc20 Fixed but with listDirectory and added tests
Signed-off-by: Diogo Monica <diogo@docker.com>
2015-07-20 19:48:17 -07:00
Aaron Lehmann
1bd55abd18 Merge pull request #107 from docker/verify_command_hash_fix
fix hash compare on verfy to be bytewise
2015-07-20 18:37:30 -07:00
Nathan McCauley
079f565f5b use consts for tuf alias comparisons
Signed-off-by: Nathan McCauley <nathan.mccauley@docker.com>
2015-07-20 18:23:02 -07:00
Nathan McCauley
6ffcb134d7 fix hash compare on verfy to be bytewise
Signed-off-by: Nathan McCauley <nathan.mccauley@docker.com>
2015-07-20 17:58:46 -07:00
Nathan McCauley
c0b0593247 Merge pull request #104 from docker/increase-cert
Changing certificate expiration time to 10 years
2015-07-20 15:21:37 -07:00
Nathan McCauley
ac7c05516d Merge pull request #103 from docker/default_expiry
update default expiry times to those agreed on
2015-07-20 15:21:23 -07:00
Nathan McCauley
d716a2fc09 Merge pull request #102 from docker/removing-swapfile
Removing swapfile
2015-07-20 14:59:27 -07:00
David Lawrence
b44e835275 update default expiry times to those agreed on
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
2015-07-20 14:59:19 -07:00
Diogo Monica
d1761eba25 Changing certificate expiration time to 10 years
Signed-off-by: Diogo Monica <diogo@docker.com>
2015-07-20 14:55:36 -07:00
Aaron Lehmann
d058c6ffe1 Removing swapfile
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2015-07-20 13:51:23 -07:00
Aaron Lehmann
ac7dc73830 Merge pull request #100 from docker/key_caching-aaronl
Key caching
2015-07-20 13:50:04 -07:00
Diogo Monica
f7ea67cfab Rebased from master
Signed-off-by: Diogo Monica <diogo@docker.com>
2015-07-20 13:46:01 -07:00
Diogo Monica
4dfe45d64e Changing testify import
Signed-off-by: Diogo Monica <diogo@docker.com>
2015-07-20 13:36:03 -07:00
Diogo Monica
42ded6231c Converted tests to testify and EC generation
Signed-off-by: Diogo Monica <diogo@docker.com>
2015-07-20 13:36:03 -07:00
Aaron Lehmann
1aced67471 Improvements to keystore caching
* RemoveKey must purge the cache entry

* Add mutexes to KeyFileStore and KeyMemoryStore so the cachedKeys map
  is protected in the case that keystore operations happen from multiple
  goroutines

* Change GetKey to return the alias along with the key. Remove
  GetKeyAlias. This simplifies the code flows that retrieve the alias
  (since they usually get the key and alias together).

* Fix tests affected by key caching

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2015-07-20 13:36:03 -07:00
Nathan McCauley
1421f47258 keystore caching
Signed-off-by: Nathan McCauley <nathan.mccauley@docker.com>
2015-07-20 13:34:11 -07:00
Nathan McCauley
ff2e583439 Merge pull request #101 from dmcgowan/passphrase-util
Move passphrase logic to its own package
2015-07-20 13:15:20 -07:00
Derek McGowan
c35c1ea254 Move passphrase logic to its own package
The logic to retrieve passphrase is generic and may be used by directly by clients.

Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
2015-07-20 13:02:05 -07:00
Diogo Mónica
a5df3c00cc Merge pull request #89 from docker/general_cleanup
WIP general cleanup
2015-07-20 12:45:03 -07:00
David Lawrence
7ce7e5815e fixing 'writing data' log message
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
2015-07-20 11:47:30 -07:00
David Lawrence
7c05c0e334 breaking out role initialization to shorten NotaryRepository.Initialize a bit
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
2015-07-20 11:47:30 -07:00
David Lawrence
20b60d9cc2 cleaning up cache vs filestore
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
2015-07-20 11:47:30 -07:00
Diogo Mónica
ca98668cfc Merge pull request #99 from docker/update_gotuf
updating gotuf dep
2015-07-20 11:46:05 -07:00
Diogo Mónica
54b312754f Merge pull request #72 from docker/passphrase_callbacks
Update keyfilestore to use passwordRetriever
2015-07-20 11:45:45 -07:00
Diogo Monica
f3a7fdf211 Removing doubling of string in test
Signed-off-by: Diogo Monica <diogo@docker.com>
2015-07-20 11:42:10 -07:00
David Lawrence
0e2fe2137b updating gotuf dep
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
2015-07-20 11:23:07 -07:00
Nathan McCauley
6b23e7d249 review feedback
Signed-off-by: Nathan McCauley <nathan.mccauley@docker.com>
2015-07-20 11:10:13 -07:00
Nathan McCauley
75ae5b65df remove incorrect TODO comment
Signed-off-by: Nathan McCauley <nathan.mccauley@docker.com>
2015-07-20 11:00:24 -07:00
Nathan McCauley
bc939bdf1f basic caching of root password for notary cli
Signed-off-by: Nathan McCauley <nathan.mccauley@docker.com>
2015-07-20 11:00:24 -07:00
Nathan McCauley
f07876602f add test for passphraseRetriever
Signed-off-by: Nathan McCauley <nathan.mccauley@docker.com>
2015-07-20 11:00:24 -07:00
Nathan McCauley
0642da80f1 review feedback
Signed-off-by: Nathan McCauley <nathan.mccauley@docker.com>
2015-07-20 11:00:24 -07:00
Nathan McCauley
38fe6bd45b gofmt across the baord
Signed-off-by: Nathan McCauley <nathan.mccauley@docker.com>
2015-07-20 11:00:24 -07:00
Nathan McCauley
de6f65b7e7 many testing fixups to support key aliasing
Signed-off-by: Nathan McCauley <nathan.mccauley@docker.com>
2015-07-20 11:00:22 -07:00
Nathan McCauley
f239757dfd keystore aliasing, take 2
Signed-off-by: Nathan McCauley <nathan.mccauley@docker.com>
2015-07-20 10:58:20 -07:00