centersl/chrome-extensions-samples
1
0
Fork 0
mirror of https://github.com/GoogleChrome/chrome-extensions-samples.git synced 2026-03-26 13:19:49 +07:00
Code Issues Packages Projects Releases Wiki Activity

removed unused variables, switched to async/await, cleanup (#906)

Browse Source 
* removed unused variables, switched to async/await, cleanup

* leave decision to await promise to caller
This commit is contained in:
Benjamin Lörincz
2023-10-10 15:37:11 +02:00
committed by GitHub
parent a1c97b522e
commit 477973e48e
1 changed files with 19 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
api-samples/alarms/index.js
View File

@@ -9,7 +9,6 @@ const log = document.querySelector('.alarm-log');
const form = document.querySelector('.create-alarm');
const clearButton = document.getElementById('clear-display');
const refreshButton = document.getElementById('refresh-display');
const pad = (val, len = 2) => val.toString().padStart(len, '0');
// DOM event bindings
@@ -94,17 +93,12 @@ class AlarmManager {
};
async cancelAlarm(name) {
// TODO: Remove custom promise wrapper once the Alarms API supports promises
return new Promise((resolve) => {
chrome.alarms.clear(name, (wasCleared) => {
if (wasCleared) {
this.logMessage(`Manager: canceled alarm "${name}"`);
} else {
this.logMessage(`Manager: could not canceled alarm "${name}"`);
}
resolve(wasCleared);
});
return chrome.alarms.clear(name, (wasCleared) => {
if (wasCleared) {
this.logMessage(`Manager: canceled alarm "${name}"`);
} else {
this.logMessage(`Manager: could not canceled alarm "${name}"`);
}
});
}
@@ -131,30 +125,21 @@ class AlarmManager {
}
async cancelAllAlarms() {
// TODO: Remove custom promise wrapper once the Alarms API supports promises
return new Promise((resolve) => {
chrome.alarms.clearAll((wasCleared) => {
if (wasCleared) {
this.logMessage(`Manager: canceled all alarms"`);
} else {
this.logMessage(`Manager: could not canceled all alarms`);
}
resolve(wasCleared);
});
return chrome.alarms.clearAll((wasCleared) => {
if (wasCleared) {
this.logMessage(`Manager: canceled all alarms"`);
} else {
this.logMessage(`Manager: could not canceled all alarms`);
}
});
}
async populateDisplay() {
// TODO: Remove custom promise wrapper once the Alarms API supports promises
return new Promise((resolve) => {
chrome.alarms.getAll((alarms) => {
for (const [index, alarm] of alarms.entries()) {
const isLast = index === alarms.length - 1;
this.renderAlarm(alarm, isLast);
}
resolve();
});
return chrome.alarms.getAll((alarms) => {
for (const [index, alarm] of alarms.entries()) {
const isLast = index === alarms.length - 1;
this.renderAlarm(alarm, isLast);
}
});
}
@@ -169,7 +154,8 @@ class AlarmManager {
this.#refreshing = true; // acquire lock
try {
await Promise.all([this.clearDisplay(), this.populateDisplay()]);
await this.clearDisplay();
await this.populateDisplay();
} finally {
this.#refreshing = false; // release lock
}