centersl/chrome-extensions-samples
1
0
Fork 0
mirror of https://github.com/GoogleChrome/chrome-extensions-samples.git synced 2026-03-26 13:19:49 +07:00
Code Issues Packages Projects Releases Wiki Activity

Allow rule creation in sample.dnr-rule-manager when no rule exists (#1029)

Browse Source 
The `functional-samples/sample.dnr-rule-manager` example allows the user to add and remove `chrome.declarativeNetRequest` rules on demand from the extension's options page.

Rules require to have a unique `id`, so the extension fetches the list of all the currently defined rules, takes the max and adds 1.

When no rule is defined, this results in `Math.max(...[]) + 1` => `Math.max() + 1` => `-Infinity + 1` => `-Infinity` and since the `id` should be an integer and not an number, the extension throws an error.

Ensuring that `0` is always a parameter of `Math.max` should solve the problem.
This commit is contained in:
Enrico Bacis
2023-11-13 14:27:09 +01:00
committed by GitHub
parent 5be3966b66
commit 38f60eb2d4
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
functional-samples/sample.dnr-rule-manager/manager.js
View File

@@ -5,7 +5,7 @@ const viewRuleButton = document.getElementById('viewRuleButton');
async function getNextRuleId() {
const rules = await chrome.declarativeNetRequest.getDynamicRules();
return Math.max(...rules.map((rule) => rule.id)) + 1;
return Math.max(0, ...rules.map((rule) => rule.id)) + 1;
}
async function refresh() {