From abdcc839d77dc87e5d9842bfc8047ae38777e231 Mon Sep 17 00:00:00 2001 From: sorbaugh Date: Tue, 31 Oct 2023 17:55:32 +0100 Subject: [PATCH 1/2] document removal of OCP/Comments for 28 Signed-off-by: Stephan Orbaugh --- .../app_upgrade_guide/upgrade_to_28.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_28.rst b/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_28.rst index d59363bb8..05a322c44 100644 --- a/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_28.rst +++ b/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_28.rst @@ -31,7 +31,7 @@ Added APIs * File actions: to register file actions, please use the dedicated API from https://npmjs.org/@nextcloud/files or https://nextcloud-libraries.github.io/nextcloud-files/functions/registerFileAction.html -* New file menu: to register entries in the new file menu, please use the dedicated API from https://npmjs.org/@nextcloud/files or +* New file menu: to register entries in the new file menu, please use the dedicated API from https://npmjs.org/@nextcloud/files or https://nextcloud-libraries.github.io/nextcloud-files/functions/addNewFileMenuEntry.html * Reminder from 27, to interact with the Files app router, use ``OCP.Files.Router``. See :ref:`FilesAPI` * To Interact with the Files app data, please use the following events. All of them have a `Node object `_ as main parameter. @@ -58,6 +58,7 @@ Removed APIs * ``OC.loadScript`` and ``OC.loadStyle``: Use ``OCP.Loader`` instead. * ``OC.appSettings``: There is no replacement. * ``OCA.Files``: Everything removed but Sidebar and Settings. See the Added API section for replacements. +* ``OCP.Comments``: Removed comments loading. Back-end changes ---------------- From 663a9e45d3f06ce83a11e4ef0b20496a8f8ab93a Mon Sep 17 00:00:00 2001 From: sorbaugh Date: Tue, 31 Oct 2023 23:10:29 +0100 Subject: [PATCH 2/2] Ammend documentation to mention removal both on Frontend and Backend sections Signed-off-by: Stephan Orbaugh --- .../app_upgrade_guide/upgrade_to_28.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_28.rst b/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_28.rst index 05a322c44..eeecd3c2c 100644 --- a/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_28.rst +++ b/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_28.rst @@ -58,7 +58,7 @@ Removed APIs * ``OC.loadScript`` and ``OC.loadStyle``: Use ``OCP.Loader`` instead. * ``OC.appSettings``: There is no replacement. * ``OCA.Files``: Everything removed but Sidebar and Settings. See the Added API section for replacements. -* ``OCP.Comments``: Removed comments loading. +* ``OCA.Comments``: There is no replacement. Back-end changes ---------------- @@ -170,6 +170,7 @@ Removed APIs * ``\OC_Defaults::getLogoClaim``: There is no replacement. * ``\OC::$server->createEventSource()`` has been removed, use ``\OCP\Server::get(\OCP\IEventSourceFactory::class)->create()`` instead. * ``\OCP\Util::writeLog`` has been removed, use ``\OCP\Server::get(LoggerInterface::class)->…`` instead. +* ``\OCP\Comments::load``: there is no replacement. The factory ``\OCP\IEventSourceFactory`` works only from Nextcloud 28. For older versions use ``\OC::$server->createEventSource()``.