From df8f3aad7cb8272ee0676412ea6e0bb7cbc8c160 Mon Sep 17 00:00:00 2001 From: Vitor Mattos Date: Mon, 17 Oct 2022 12:48:49 -0300 Subject: [PATCH 1/2] Remove expose email as mandatory Signed-off-by: Vitor Mattos --- .../app_publishing_maintenance/code_signing.rst | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/developer_manual/app_publishing_maintenance/code_signing.rst b/developer_manual/app_publishing_maintenance/code_signing.rst index da6da0a94..f238ded71 100644 --- a/developer_manual/app_publishing_maintenance/code_signing.rst +++ b/developer_manual/app_publishing_maintenance/code_signing.rst @@ -119,11 +119,10 @@ examples will assume that you are trying to sign an application named "contacts". 1. Generate a private key and CSR: ``openssl req -nodes -newkey rsa:4096 -keyout contacts.key -out contacts.csr -subj "/CN=contacts"``. Replace "contacts" with your application identifier. -2. Post the CSR at https://github.com/nextcloud/app-certificate-requests, and configure - your GitHub account to show your mail address in your profile. Nextcloud - might ask you for further information to verify that you're the legitimate - owner of the application. Make sure to keep the private key file (``contacts.key``) - secret and not disclose it to any third parties. +2. Post the CSR at https://github.com/nextcloud/app-certificate-requests, in a + new pull request whith the link of a public repository with the code of your + app. Make sure to keep the private key file (``contacts.key``) secret and + not disclose it to any third parties. 3. Nextcloud will provide you with the signed certificate. 4. Run ``./occ integrity:sign-app`` to sign your application, and specify your private and public keys as well as the path to the application. From 4a1bbfb2e2c04d365101936e3156c595da841ef6 Mon Sep 17 00:00:00 2001 From: Vitor Mattos Date: Mon, 17 Oct 2022 12:50:35 -0300 Subject: [PATCH 2/2] Fix typo Signed-off-by: Vitor Mattos --- developer_manual/app_publishing_maintenance/code_signing.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/developer_manual/app_publishing_maintenance/code_signing.rst b/developer_manual/app_publishing_maintenance/code_signing.rst index f238ded71..15bfa430f 100644 --- a/developer_manual/app_publishing_maintenance/code_signing.rst +++ b/developer_manual/app_publishing_maintenance/code_signing.rst @@ -120,7 +120,7 @@ examples will assume that you are trying to sign an application named 1. Generate a private key and CSR: ``openssl req -nodes -newkey rsa:4096 -keyout contacts.key -out contacts.csr -subj "/CN=contacts"``. Replace "contacts" with your application identifier. 2. Post the CSR at https://github.com/nextcloud/app-certificate-requests, in a - new pull request whith the link of a public repository with the code of your + new pull request with the link of a public repository with the code of your app. Make sure to keep the private key file (``contacts.key``) secret and not disclose it to any third parties. 3. Nextcloud will provide you with the signed certificate.