From 7f31f7043e657ea77a9dd812db7bfb70163821e3 Mon Sep 17 00:00:00 2001 From: Christopher Ng Date: Mon, 26 Aug 2024 17:00:44 -0700 Subject: [PATCH] feat(developer): Document new encode flags for JSONResponse Signed-off-by: Christopher Ng --- .../app_upgrade_guide/upgrade_to_30.rst | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_30.rst b/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_30.rst index b7759e330..fc641a0ca 100644 --- a/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_30.rst +++ b/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_30.rst @@ -33,7 +33,7 @@ Front-end changes Clickable area ^^^^^^^^^^^^^^ -The size of the CSS variable ``--clickable-area`` variable has shrunk from ``44px`` to ``34px``. +The size of the CSS variable ``--clickable-area`` variable has shrunk from ``44px`` to ``34px``. This will result in several regressions and paper-cuts in your app that will need to be manually fixed. It's recommended to: @@ -46,8 +46,8 @@ It's recommended to: Line height ^^^^^^^^^^^ -The ``--default-line-height`` variable has changed from ``24px``` to ``1.5`` for the ``--default-font-size`` this -means that the actual value in pixel will go from 24 to 22.5. Although this is a slight change, it's recommended +The ``--default-line-height`` variable has changed from ``24px``` to ``1.5`` for the ``--default-font-size`` this +means that the actual value in pixel will go from 24 to 22.5. Although this is a slight change, it's recommended to check for visual regressions in your app. @@ -194,6 +194,7 @@ Added APIs - ``OCP\AppFramework\Bootstrap\IRegistrationContext::registerTaskProcessingTaskType()`` was added to allow registering task processing task types - ``OCP\Files\IRootFolder::getAppDataDirectoryName()`` was added to allow getting the name of the app data directory - ``OCP\Security\IHasher::validate()`` should return true if the passed string is a valid hash generated by ``OCP\Security\IHasher::hash()`` +- ``OCP\AppFramework\Http\JSONResponse()`` constructor now supports passing additional ``json_encode`` flags, see https://www.php.net/manual/en/function.json-encode.php for details Changed APIs ^^^^^^^^^^^^