From 5435dcd708fef828b4199cb9d0356401c47a5da5 Mon Sep 17 00:00:00 2001 From: Christian Wolf Date: Fri, 28 Feb 2025 18:05:11 +0100 Subject: [PATCH] Apply suggestions from code review Add first batch of changes to be incorporated. Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com> Signed-off-by: Christian Wolf --- developer_manual/basics/controllers.rst | 4 ++-- developer_manual/basics/routing.rst | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/developer_manual/basics/controllers.rst b/developer_manual/basics/controllers.rst index a9360197d..14896c5a4 100644 --- a/developer_manual/basics/controllers.rst +++ b/developer_manual/basics/controllers.rst @@ -478,7 +478,7 @@ For ``OCSController`` classes and their methods, :ref:`responders ` to the routing table in ``appinfo/routes.php`` of your app. Inside these, there are the same information as there are for normal routes. @@ -883,7 +883,7 @@ Here is the example from :ref:`OCS controllers `: } -The ``#[NoAdminRequired]`` is needed here as normal users should be able to access the data in fact. +The ``#[NoAdminRequired]`` is needed here as normal users should be able to access the data. It can be left out in case only the admin user should be able to access the data. The CSRF check is still active. Thus, the client must obey the corresponding requirements. diff --git a/developer_manual/basics/routing.rst b/developer_manual/basics/routing.rst index acb478d4e..13f933645 100644 --- a/developer_manual/basics/routing.rst +++ b/developer_manual/basics/routing.rst @@ -44,7 +44,7 @@ Additionally, the route must be configured to be an OCS route in the router. To do so, you use the ``ocs`` key in the ``routes.php`` file instead of the key ``routes``. The rest of the structure is the same. -You can of course combine non-OCS with OCS routes. +You can of course have both index.php and OCS routes. .. code-block:: php