mirror of https://github.com/lobehub/lobehub.git synced 2026-03-26 13:19:34 +07:00

Files

Arvin Xu 83fc2e8bc6 🐛 fix(desktop): add token refresh retry mechanism (#10575 )

* 🐛 fix(desktop): add token refresh retry mechanism

- Add `async-retry` library for exponential backoff retry
- Implement retry logic in RemoteServerConfigCtr.refreshAccessToken()
  - Retries up to 3 times with exponential backoff (1s, 2s, 4s)
  - Distinguishes between retryable (network) and non-retryable (invalid_grant) errors
- Update AuthCtr to only clear tokens for non-retryable errors
  - Transient errors now preserve tokens for retry on next cycle
- Add isNonRetryableError() helper method

This fixes the issue where temporary network problems would cause
users to be logged out and require re-authorization.

Closes LOBE-1368

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* update

* 🐛 fix: treat deterministic failures as non-retryable errors

Add deterministic failures to non-retryable error list:
- 'No refresh token available' - refresh token missing from storage
- 'Remote server is not active or configured' - config invalid/disabled
- 'Missing tokens in refresh response' - server returned incomplete response

These permanent failures now trigger immediate token clearing and
authorizationRequired broadcast instead of infinite retry loop.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* 📝 docs: clarify issue status workflow - use "In Review" after PR creation

- Change workflow to set status to "In Review" when PR is created
- "Done" status should only be set after PR is merged
- Add note about Linear-GitHub integration for auto status update

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* 🐛 fix: add grace period for consumed RefreshToken

When rotateRefreshToken is enabled, the old refresh token is consumed
when a new one is issued. If the client fails to receive/save the new
token (network issues, crashes), the login state is lost.

This adds a 3-minute grace period allowing consumed refresh tokens to
be reused, giving clients a chance to retry the refresh operation.

Changes:
- Add REFRESH_TOKEN_GRACE_PERIOD_SECONDS constant (180s)
- Modify find() to allow RefreshToken reuse within grace period
- Add unit tests for grace period behavior

Closes LOBE-1369

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* 📝 style: translate adapter test descriptions to English

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>

2025-12-03 15:46:14 +08:00

3.7 KiB

Raw Blame History

CLAUDE.md

This document serves as a shared guideline for all team members when using Claude Code in this repository.

Tech Stack

read @.cursor/rules/project-introduce.mdc

Directory Structure

read @.cursor/rules/project-structure.mdc

Development

Git Workflow

The current release branch is next instead of main until v2.0.0 is officially released
use rebase for git pull
git commit message should prefix with gitmoji
git branch name format example: tj/feat/feature-name
use .github/PULL_REQUEST_TEMPLATE.md to generate pull request description

Package Management

This repository adopts a monorepo structure.

Use pnpm as the primary package manager for dependency management
Use bun to run npm scripts
Use bunx to run executable npm packages

TypeScript Code Style Guide

see @.cursor/rules/typescript.mdc

Testing

Required Rule: read @.cursor/rules/testing-guide/testing-guide.mdc before writing tests
Command:
- web: bunx vitest run --silent='passed-only' '[file-path-pattern]'
- packages(eg: database): cd packages/database && bunx vitest run --silent='passed-only' '[file-path-pattern]'

Important:

wrap the file path in single quotes to avoid shell expansion
Never run bun run test etc to run tests, this will run all tests and cost about 10mins
If trying to fix the same test twice, but still failed, stop and ask for help.

Typecheck

use bun run type-check to check type errors.

i18n

Keys: Add to src/locales/default/namespace.ts
Dev: Translate locales/zh-CN/namespace.json and locales/en-US/namespace.json locales file only for dev preview
DON'T run pnpm i18n, let CI auto handle it

Linear Issue Management

When working with Linear issues:

Retrieve issue details before starting work using mcp__linear-server__get_issue
Check for sub-issues: If the issue has sub-issues, retrieve and review ALL sub-issues using mcp__linear-server__list_issues with parentId filter before starting work
Update issue status when completing tasks using mcp__linear-server__update_issue
MUST add completion comment using mcp__linear-server__create_comment

Completion Comment (REQUIRED)

Every time you complete an issue, you MUST add a comment summarizing the work done. This is critical for:

Team visibility and knowledge sharing
Code review context
Future reference and debugging

IMPORTANT: Per-Issue Completion Rule

When working on multiple issues (e.g., parent issue with sub-issues), you MUST update status and add comment for EACH issue IMMEDIATELY after completing it. Do NOT wait until all issues are done to update them in batch.

Workflow for EACH individual issue:

Complete the implementation for this specific issue
Run type check: bun run type-check
Run related tests if applicable
Create PR if needed
IMMEDIATELY update issue status to "In Review" (NOT "Done"): mcp__linear-server__update_issue
IMMEDIATELY add completion comment: mcp__linear-server__create_comment
Only then move on to the next issue

Note: Issue status should be set to "In Review" when PR is created. The status will be updated to "Done" only after the PR is merged (usually handled by Linear-GitHub integration or manually).

❌ Wrong approach:

Complete Issue A → Complete Issue B → Complete Issue C → Update all statuses → Add all comments
Mark issue as "Done" immediately after creating PR

✅ Correct approach:

Complete Issue A → Create PR → Update A status to "In Review" → Add A comment → Complete Issue B → ...

Rules Index

Some useful project rules are listed in @.cursor/rules/rules-index.mdc

3.7 KiB Raw Blame History