centersl/lobehub
1
0
Fork 0
mirror of https://github.com/lobehub/lobehub.git synced 2026-03-27 13:29:15 +07:00
Code Issues Packages Projects Releases Wiki Activity

🐛 fix: only include input_fidelity parameter for gpt-image-1. (#9920)

Browse Source 
fix: only include input_fidelity parameter for gpt-image-1.

The input_fidelity parameter was incorrectly sent to all models during image editing, causing errors with DALL-E 2 and gpt-5-image-mini.
This commit is contained in:
Taehyung Lee
2025-10-31 01:24:24 +09:00
committed by GitHub
parent e303979e0f
commit 65dbc6383d
2 changed files with 34 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/model-runtime/src/core/openaiCompatibleFactory/createImage.ts
View File

@@ -67,7 +67,7 @@ async function generateByImageMode(
const defaultInput = {
n: 1,
...(model.includes('dall-e') ? { response_format: 'b64_json' } : {}),
...(isImageEdit ? { input_fidelity: 'high' } : {}),
...(isImageEdit && model === 'gpt-image-1' ? { input_fidelity: 'high' } : {}),
};
const options = cleanObject({

36
packages/model-runtime/src/core/openaiCompatibleFactory/index.test.ts
View File

@@ -1254,7 +1254,6 @@ describe('LobeOpenAICompatibleFactory', () => {
);
expect(instance['client'].images.edit).toHaveBeenCalledWith({
image: expect.any(File),
input_fidelity: 'high',
mask: 'https://example.com/mask.jpg',
model: 'dall-e-2',
n: 1,
@@ -1301,7 +1300,6 @@ describe('LobeOpenAICompatibleFactory', () => {
expect(instance['client'].images.edit).toHaveBeenCalledWith({
image: [mockFile1, mockFile2],
input_fidelity: 'high',
model: 'dall-e-2',
n: 1,
prompt: 'Merge these images',
@@ -1330,6 +1328,39 @@ describe('LobeOpenAICompatibleFactory', () => {
'Failed to convert image URLs to File objects: Error: Failed to download image',
);
});
it('should include input_fidelity parameter for gpt-image-1 model', async () => {
const mockResponse = {
data: [{ b64_json: 'gpt-image-edited-base64' }],
};
const mockFile = new File(['content'], 'test-image.jpg', { type: 'image/jpeg' });
vi.mocked(openaiHelpers.convertImageUrlToFile).mockResolvedValue(mockFile);
vi.spyOn(instance['client'].images, 'edit').mockResolvedValue(mockResponse as any);
const payload = {
model: 'gpt-image-1',
params: {
imageUrl: 'https://example.com/image.jpg',
prompt: 'Edit this image with gpt-image-1',
},
};
const result = await (instance as any).createImage(payload);
expect(instance['client'].images.edit).toHaveBeenCalledWith({
image: expect.any(File),
input_fidelity: 'high',
model: 'gpt-image-1',
n: 1,
prompt: 'Edit this image with gpt-image-1',
});
expect(result).toEqual({
imageUrl: 'data:image/png;base64,gpt-image-edited-base64',
});
});
});
describe('error handling', () => {
@@ -1431,7 +1462,6 @@ describe('LobeOpenAICompatibleFactory', () => {
expect(instance['client'].images.edit).toHaveBeenCalledWith({
customParam: 'should remain unchanged',
image: expect.any(File),
input_fidelity: 'high',
model: 'dall-e-2',
n: 1,
prompt: 'Test prompt',