centersl/lobehub
1
0
Fork 0
mirror of https://github.com/lobehub/lobehub.git synced 2026-03-27 13:29:15 +07:00
Code Issues Packages Projects Releases Wiki Activity

🐛 fix(electron): correct next config codemod pattern matching (#11228)

Browse Source 
- Use findAll with kind: 'pair' instead of find with pattern for redirects
- Add webVitalsAttribution removal logic
- Improve pattern matching to handle spacing variations
- Add invariant checks for better error handling

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Innei
2026-01-05 14:29:52 +08:00
committed by GitHub
parent 3a30d9aed1
commit 06cb019b8e
1 changed files with 41 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
scripts/electronWorkflow/modifiers/nextConfig.mts
View File

@@ -40,13 +40,19 @@ export const modifyNextConfig = async (TEMP_DIR: string) => {
}
// 1. Remove redirects
const redirectsPair = nextConfigDecl.find({
rule: {
pattern: 'redirects: $A',
},
});
if (redirectsPair) {
const range = redirectsPair.range();
const redirectsPair = nextConfigDecl
.findAll({
rule: {
kind: 'pair',
},
})
.find((node) => {
const text = node.text();
return text.startsWith('redirects:') || text.startsWith('redirects :');
});
invariant(redirectsPair, '[modifyNextConfig] redirects pair not found');
{
const range = redirectsPair!.range();
edits.push({ end: range.end.index, start: range.start.index, text: '' });
}
@@ -61,18 +67,39 @@ export const modifyNextConfig = async (TEMP_DIR: string) => {
const text = node.text();
return text.startsWith('async headers') || text.startsWith('headers');
});
if (headersMethod) {
const range = headersMethod.range();
invariant(headersMethod, '[modifyNextConfig] headers method not found');
{
const range = headersMethod!.range();
edits.push({ end: range.end.index, start: range.start.index, text: '' });
}
// 3. Remove spread element
// 3. Remove webVitalsAttribution
const webVitalsPair = nextConfigDecl
.findAll({
rule: {
kind: 'pair',
},
})
.find((node) => {
const text = node.text();
return (
text.startsWith('webVitalsAttribution:') || text.startsWith('webVitalsAttribution :')
);
});
invariant(webVitalsPair, '[modifyNextConfig] webVitalsAttribution pair not found');
{
const range = webVitalsPair!.range();
edits.push({ end: range.end.index, start: range.start.index, text: '' });
}
// 4. Remove spread element
const spreads = nextConfigDecl.findAll({
rule: {
kind: 'spread_element',
},
});
// eslint-disable-next-line unicorn/consistent-function-scoping
const isObjectLevelSpread = (node: any) => node.parent()?.kind() === 'object';
const standaloneSpread = spreads.find((node) => {
@@ -84,12 +111,13 @@ export const modifyNextConfig = async (TEMP_DIR: string) => {
const objectLevelSpread = standaloneSpread ? null : spreads.find(isObjectLevelSpread);
const spreadToRemove = standaloneSpread || objectLevelSpread;
if (spreadToRemove) {
const range = spreadToRemove.range();
invariant(spreadToRemove, '[modifyNextConfig] spread element not found');
{
const range = spreadToRemove!.range();
edits.push({ end: range.end.index, start: range.start.index, text: '' });
}
// 4. Inject/force output: 'export'
// 5. Inject/force output: 'export'
const outputPair = nextConfigDecl.find({
rule: {
pattern: 'output: $A',