Yong Tang f99fd5a3f9 Idempotent service update --publish-add ...

This fix tries to address the issue raised in 25375 where
`service update --publish-add` returns an error if the exact
same value is repeated (idempotent).

This fix use a map to filter out repeated port configs so
that `--publish-add` does not error out.

An integration test has been added.

This fix fixes 25375.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
(cherry picked from commit b487497cd2d7586fd7e10affdcc514ca6b7884f6)
Signed-off-by: Tibor Vass <tibor@docker.com>

2016-08-11 17:56:51 -07:00

..

fixtures

…

benchmark_test.go

Move layer mount refcounts to mountedLayer

2016-03-23 14:42:52 -07:00

check_test.go

Split advertised address from listen address

2016-07-25 23:18:03 -07:00

daemon_swarm_hack.go

Implement service integration tests

2016-07-08 15:32:22 -07:00

daemon_swarm.go

Add --force to node removal

2016-08-11 17:56:45 -07:00

daemon.go

Swarm integration tests

2016-06-13 22:16:18 -07:00

docker_api_attach_test.go

Swarm integration tests

2016-06-13 22:16:18 -07:00

docker_api_auth_test.go

Return remote API errors as JSON

2016-06-07 18:45:27 -07:00

docker_api_build_test.go

Reimplementing builder tests for Dockerfile outside context as a unit test

2016-06-05 08:39:06 +02:00

docker_api_containers_test.go

Fix panic in stats test

2016-07-25 23:15:11 -07:00

docker_api_create_test.go

Return remote API errors as JSON

2016-06-07 18:45:27 -07:00

docker_api_events_test.go

…

docker_api_exec_resize_test.go

…

docker_api_exec_test.go

Return remote API errors as JSON

2016-06-07 18:45:27 -07:00

docker_api_images_test.go

…

docker_api_info_test.go

Remove execution driver

2016-07-12 15:50:18 -07:00

docker_api_inspect_test.go

…

docker_api_inspect_unix_test.go

…

docker_api_logs_test.go

Return remote API errors as JSON

2016-06-07 18:45:27 -07:00

docker_api_network_test.go

Update client code with api changes

2016-04-15 12:48:01 +02:00

docker_api_resize_test.go

Return remote API errors as JSON

2016-06-07 18:45:27 -07:00

docker_api_service_update_test.go

Change docker service update semantics

2016-06-18 20:58:23 -07:00

docker_api_stats_test.go

Fix flaky TestApiStatsNetworkStats test

2016-05-23 19:00:19 -07:00

docker_api_stats_unix_test.go

TestApiStatsContainerGetMemoryLimit: Add cgroup memory test

2016-05-04 20:46:41 +02:00

docker_api_swarm_test.go

Add --force to node removal

2016-08-11 17:56:45 -07:00

docker_api_test.go

Swarm integration tests

2016-06-13 22:16:18 -07:00

docker_api_update_unix_test.go

…

docker_api_version_test.go

…

docker_api_volumes_test.go

…

docker_cli_attach_test.go

Better error on attach no tty

2016-05-25 13:32:48 -07:00

docker_cli_attach_unix_test.go

…

docker_cli_authz_unix_test.go

authz: cleanups

2016-06-12 17:23:19 +02:00

docker_cli_build_test.go

Fix spelling in comments, strings and documentation

2016-07-08 15:31:42 -07:00

docker_cli_build_unix_test.go

…

docker_cli_by_digest_test.go

Treat digest only images as dangling

2016-07-08 15:32:14 -07:00

docker_cli_commit_test.go

…

docker_cli_config_test.go

…

docker_cli_cp_from_container_test.go

…

docker_cli_cp_test.go

fix typos

2016-06-02 17:17:22 +08:00

docker_cli_cp_to_container_test.go

…

docker_cli_cp_to_container_unix_test.go

…

docker_cli_cp_utils.go

…

docker_cli_create_test.go

Fix create command flags

2016-06-07 14:11:11 +02:00

docker_cli_daemon_experimental_test.go

Handle plugin shutdown when liveRestore is set.

2016-07-25 23:24:37 -07:00

docker_cli_daemon_test.go

Fix daemon tests.

2016-06-30 16:47:53 -07:00

docker_cli_diff_test.go

Fix TestDiffEmptyArgClientError O:)

2016-06-06 13:58:29 +02:00

docker_cli_events_test.go

Make daemon events listen for plugin lifecycle events.

2016-08-11 17:56:43 -07:00

docker_cli_events_unix_test.go

Use "docker-runc" as alias for the default runtime

2016-06-30 16:47:51 -07:00

docker_cli_exec_test.go

Better error on attach no tty

2016-05-25 13:32:48 -07:00

docker_cli_exec_unix_test.go

…

docker_cli_experimental_test.go

…

docker_cli_export_import_test.go

…

docker_cli_external_graphdriver_unix_test.go

Fix spelling in comments, strings and documentation

2016-07-08 15:31:42 -07:00

docker_cli_external_volume_driver_unix_test.go

Add support for volume scopes

2016-06-05 15:37:15 -04:00

docker_cli_health_test.go

Remove out-of-date health test

2016-06-16 23:36:53 -07:00

docker_cli_help_test.go

Migrate rm command to cobra

2016-06-07 22:19:16 +08:00

docker_cli_history_test.go

fix typos

2016-06-02 17:17:22 +08:00

docker_cli_images_test.go

Remove deprecated -f flag on docker tag

2016-06-01 09:44:25 -07:00

docker_cli_import_test.go

Fix docker import tests

2016-05-23 15:34:40 -07:00

docker_cli_info_test.go

Use "docker-runc" as alias for the default runtime

2016-06-30 16:47:51 -07:00

docker_cli_info_unix_test.go

Add security info to docker info

2016-06-16 23:36:56 -07:00

docker_cli_inspect_experimental_test.go

…

docker_cli_inspect_test.go

Merge pull request #23002 from Microsoft/jjh/readonly

2016-06-08 11:18:48 -07:00

docker_cli_kill_test.go

…

docker_cli_links_test.go

Fix regression on --link on bridge network

2016-07-25 23:17:08 -07:00

docker_cli_links_unix_test.go

…

docker_cli_login_test.go

…

docker_cli_logout_test.go

Change v1 pull 404 message to include tag

2016-03-29 10:04:59 -07:00

docker_cli_logs_bench_test.go

…

docker_cli_logs_test.go

Add support for reading logs extra attrs

2016-05-06 20:42:20 -04:00

docker_cli_nat_test.go

…

docker_cli_netmode_test.go

fix typos

2016-06-02 17:17:22 +08:00

docker_cli_network_unix_test.go

Rename --net to --network

2016-07-12 15:50:38 -07:00

docker_cli_oom_killed_test.go

Add the swapMemorySupport requirement to OOM tests

2016-05-10 11:28:00 -07:00

docker_cli_pause_test.go

Get events until a time in the past.

2016-04-14 16:22:16 -07:00

docker_cli_plugins_test.go

Remove plugin root from filesystem.

2016-08-11 17:56:44 -07:00

docker_cli_port_test.go

…

docker_cli_proxy_test.go

…

docker_cli_ps_test.go

Sort output of docker ps --filter with order by creation time

2016-08-11 17:56:47 -07:00

docker_cli_pull_local_test.go

fixed spelling error in cli pull local test

2016-05-19 17:52:42 -05:00

docker_cli_pull_test.go

Move implicit pull test to use local registry

2016-05-02 18:14:13 -07:00

docker_cli_pull_trusted_test.go

…

docker_cli_push_test.go

integration-cli: ensure digest is the same after cross-repo push

2016-07-08 15:32:22 -07:00

docker_cli_registry_user_agent_test.go

…

docker_cli_rename_test.go

docker rename fix to address the issue of renaming with the same name issue #23319

2016-06-30 16:47:48 -07:00

docker_cli_restart_test.go

Fix test case

2016-04-26 19:22:48 +08:00

docker_cli_rm_test.go

…

docker_cli_rmi_test.go

Use spf13/cobra for docker rmi

2016-06-05 22:40:35 +02:00

docker_cli_run_test.go

fix typos

2016-07-25 23:18:15 -07:00

docker_cli_run_unix_test.go

Add fchmod and fchmodat to TestRunSeccompProfileDenyChmod

2016-07-08 15:31:44 -07:00

docker_cli_save_load_test.go

Say something useful during docker load

2016-06-08 17:17:05 +02:00

docker_cli_save_load_unix_test.go

Fix docker load progressbar, fixes #21957

2016-04-12 22:45:42 -04:00

docker_cli_search_test.go

Use spf13/cobra for docker search

2016-06-03 19:50:01 +02:00

docker_cli_service_create_hack_test.go

Use newer default values for mounts CLI

2016-07-08 15:32:30 -07:00

docker_cli_service_health_test.go

extend health check to start service

2016-07-25 23:24:47 -07:00

docker_cli_service_update_test.go

fix panic on --label-add

2016-07-25 23:24:47 -07:00

docker_cli_sni_test.go

…

docker_cli_stack_test.go

cli: docker service|node|stack ps instead of tasks

2016-07-27 11:20:25 -07:00

docker_cli_start_test.go

Fix docker start error with renamed container

2016-06-30 16:47:37 -07:00

docker_cli_stats_test.go

Do not remove containers from stats list on err

2016-04-13 16:36:34 -04:00

docker_cli_stop_test.go

Add test case for stopping a restarting container

2016-04-10 15:39:28 +08:00

docker_cli_swarm_test.go

Idempotent service update --publish-add

2016-08-11 17:56:51 -07:00

docker_cli_tag_test.go

Remove deprecated -f flag on docker tag

2016-06-01 09:44:25 -07:00

docker_cli_top_test.go

…

docker_cli_update_test.go

…

docker_cli_update_unix_test.go

Add pause status check for --kernel-memory

2016-04-01 10:32:46 +08:00

docker_cli_userns_test.go

…

docker_cli_v2_only_test.go

…

docker_cli_version_test.go

…

docker_cli_volume_test.go

Update usage and help to (almost) match the existing docker behaviour

2016-05-31 14:41:37 -07:00

docker_cli_wait_test.go

Better logging for errors in some tests

2016-03-25 10:02:52 -04:00

docker_deprecated_api_v124_test.go

remove deprecated feature of passing HostConfig at API container start

2016-06-01 22:25:17 +08:00

docker_deprecated_api_v124_unix_test.go

remove deprecated feature of passing HostConfig at API container start

2016-06-01 22:25:17 +08:00

docker_experimental_network_test.go

Add "--ipv6" flag in IT for network create when using ipv6 subnets

2016-03-24 16:19:59 -07:00

docker_hub_pull_suite_test.go

fix typos

2016-06-02 17:17:22 +08:00

docker_test_vars.go

Use dockerd instead of docker daemon in integration-cli

2016-05-26 13:14:35 +02:00

docker_utils.go

Fix spelling in comments, strings and documentation

2016-07-08 15:31:42 -07:00

events_utils.go

Fix incorrect usage of logrus when formatting string is present

2016-06-11 15:37:36 -07:00

npipe_windows.go

…

npipe.go

…

registry_mock.go

…

registry.go

fix typos

2016-07-25 23:18:15 -07:00

requirements_unix.go

…

requirements.go

Add NoArm64 testRequires and skip Schema1RegistrySuite on arm64

2016-07-08 15:32:13 -07:00

test_vars_exec.go

…

test_vars_noexec.go

…

test_vars_noseccomp.go

…

test_vars_seccomp.go

…

test_vars_unix.go

…

test_vars_windows.go

…

trust_server.go

Remove deprecated Docker Content Trust ENV passphrase variables

2016-05-07 14:25:28 -07:00

utils.go

…