* edit: updated `Security scanning` section
`docker scan` fails when user is not logged in to Docker Hub. First I had to use `docker login` to login to Docker Hub. Afterwards, `docker scan` worked.
* Update 09_image_best.md
Update format, fix a typo
Co-authored-by: Usha Mandya <47779042+usha-mandya@users.noreply.github.com>
The current documentation references the newer todo list built in the [Getting Started demo](https://docs.docker.com/get-started/02_our_app/) built in previous steps, but the docs listed the code for the older [BulletinBoard:1.0 image](http://www.myclass5.cn/get-started/part2/). So, this patch applies the following to run Getting Started:
- changed the name of the image to `getting-started`, and rebuild the image using `docker build -t getting-started .`
- changed the port numbers under the `ports` key in the Kubernetes YAML to *3000*
* Updated `## Persist the todo data` section
I provided a 3-step procedure from lines 81 to 102 on how to access the container's shell environment, since It was unclear how to access the `/etc/todos` directory. Also, nowhere, in the tutorial, was it mentioned that containers are *self-contained shell environments*. This information is crucial for beginners following along with the tutorial.
Take care.
* Second update
This update was due to a suggestion provided by @thaJeztah .
Adjust text, add modal pop-up for browsers with JavaScript enabled, and show
EULA inline for browsers without JavaScript.
Added configuration options in the _config.json to set the correct URLs
once known.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Indentation in some bullet-lists had one space too little, causing
code-highlighting to not work.
Also fixed some other minor issues.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- Add missing code-hints (console, yaml)
- Consistently add an empty line after code-blocks
- Combine some examples where the output and the command were
put in separate blocks. With the "console" code-hint, this
is no longer nescessary.
- fix indentation in cloud/ecs-integration.md, which caused the
numbered-list to be interrupted.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
In the "Run the application stack" part, I think there is a mistake in writing. That is "If you don't already, you'll see output that looks like this...". I change it to "If you have done already, you'll see output that looks like this...".
* Change wording to match "docker rm -f" command
Wording says *stop* when the corresponding command is `docker rm -f`.
* Clarify stop and remove
As the container is still running, this step stops the container and then removes it.
Co-authored-by: Usha Mandya <47779042+usha-mandya@users.noreply.github.com>
BuildKit allows using alternative Dockerfile syntaxes to introduce new features
without having to update Docker itself. The general recommendation is to always
specify a "syntax" directive in a Dockerfile, so that (if needed) older versions
of Docker can download the correct syntax to build the Dockerfile.
This updates our examples to include a syntax directive, to make users more familiar
with these directives, and to illustrate best-pracitces in our documentation.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
