Alexandr Morozov
55cac6c942
Benchmark for StdWriter.Write
...
Signed-off-by: Alexandr Morozov <lk4d4@docker.com >
2014-09-17 19:24:07 +04:00
unclejack
277aa9c674
stdcopy: improve perf by avoiding buffer growth
...
Docker-DCO-1.1-Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com > (github: unclejack)
2014-09-17 18:06:17 +03:00
unclejack
1f03e60c2a
move stdcopy to pkg/stdcopy
...
Docker-DCO-1.1-Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com > (github: unclejack)
2014-09-17 18:06:17 +03:00
Vincent Batts
0a6fd743ea
Merge pull request #8063 from jlhawn/tarsum_empty_tar_archive
...
tarsum: correct close and finish reads
2014-09-16 15:41:28 -04:00
Tibor Vass
28f09f0632
Merge pull request #8059 from estesp/8057-refactor-regexp-to-package-var
...
Refactor all pre-compiled regexp to package level vars
2014-09-16 15:04:23 -04:00
Phil Estes
4119c9d7d9
Refactor all pre-compiled regexp to package level vars
...
Addresses #8057
Docker-DCO-1.1-Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com >
2014-09-16 12:57:44 -04:00
Josh Hawn
bc956c6b79
Correct tarsum finish logic
...
Tarsum now correctly closes the internal TarWriter which appends
a block of 1024 zeros to the end of the returned archive.
Signed-off-by: Josh Hawn <josh.hawn@docker.com >
2014-09-16 09:34:21 -07:00
Vincent Batts
0ecafb8a69
tarsum: version the addition of xattrs
...
Now that TarSum can be versioned, move the addition of xattr headers in
to the next version of TarSum
Signed-off-by: Vincent Batts <vbatts@redhat.com >
2014-09-15 16:08:05 -04:00
Vincent Batts
448c8ecb0f
tarsum: include xattr headers in to the checksum
...
this is to enhance the tarsum algorithm, but _MUST_ be done in lock step
with the same for docker-registry. (PR will be cited)
Docker-DCO-1.1-Signed-off-by: Vincent Batts <vbatts@redhat.com > (github: vbatts)
2014-09-15 15:05:01 -04:00
Vincent Batts
ec01eb653d
tarsum: TarSum is not the interface
...
don't export the exsisting TarSum struct and call the interface 'TarSum'
instead.
Signed-off-by: Vincent Batts <vbatts@redhat.com >
2014-09-10 21:56:20 -04:00
Vincent Batts
747f89cd32
TarSum: versioning
...
This introduces Versions for TarSum checksums.
Fixes: https://github.com/docker/docker/issues/7526
It preserves current functionality and abstracts the interface for
future flexibility of hashing algorithms. As a POC, the VersionDev
Tarsum does not include the mtime in the checksum calculation, and would
solve https://github.com/docker/docker/issues/7387 though this is not a
settled Version is subject to change until a version number is assigned.
Signed-off-by: Vincent Batts <vbatts@redhat.com >
2014-09-10 15:41:52 -04:00
Vincent Batts
197f9b1e2b
Merge pull request #7921 from unclejack/increase_tarsum_buffer_size
...
pkg/tarsum: make buffer size dynamic
2014-09-09 16:10:02 -04:00
Vincent Batts
6a8cae3e03
tarsum: use Debugf, not Infof
...
Signed-off-by: Vincent Batts <vbatts@redhat.com >
2014-09-09 14:07:20 -04:00
unclejack
7ef3440750
pkg/tarsum: add dynamic buffer sizing
...
This commit makes tarsum buffer allocation dynamic. This change
is required to avoid allocating memory excessively after the archive
buffering changes.
Docker-DCO-1.1-Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com > (github: unclejack)
2014-09-06 17:39:43 +03:00
unclejack
2d2016b81b
pkg/pool: add pools for bufio readers & writers
...
Docker-DCO-1.1-Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com > (github: unclejack)
2014-09-03 11:36:39 +03:00
unclejack
bd130e72a0
pkg/ioutils: add ReaderErrWrapper to readers
...
Docker-DCO-1.1-Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com > (github: unclejack)
2014-09-03 11:36:21 +03:00
unclejack
c93b9e81c0
pkg/ioutils: add NewBufReaderWithDrainbufAndBuffer
...
Docker-DCO-1.1-Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com > (github: unclejack)
2014-09-03 11:36:21 +03:00
unclejack
7b6f34057c
pkg/ioutils: add WriteCloserWrapper
...
Docker-DCO-1.1-Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com > (github: unclejack)
2014-09-03 11:36:21 +03:00
unclejack
76212635b5
move some io related utils to pkg/ioutils
...
Docker-DCO-1.1-Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com > (github: unclejack)
2014-09-03 11:36:21 +03:00
Michael Crosby
ec87846908
Merge pull request #7809 from LK4D4/use_increment
...
Use increment operator
2014-09-01 11:16:25 -07:00
Alexandr Morozov
16e850fe3e
Use increment operator
...
Signed-off-by: Alexandr Morozov <lk4d4math@gmail.com >
2014-08-30 21:43:48 +04:00
Sven Dowideit
f1934e5979
fs.Visit() returns nil flag
...
Signed-off-by: Sven Dowideit <SvenDowideit@docker.com >
2014-08-29 15:38:03 +10:00
Michael Crosby
334dca15b0
Merge pull request #7647 from ewindisch/erw-tarsum-maintainer
...
Add Eric Windisch to MAINTAINER for tarsum
2014-08-27 20:00:19 -07:00
Erik Hollensbe
9f09ef18a4
pkg/networkfs/etchosts: tests for Update method
...
Docker-DCO-1.1-Signed-off-by: Erik Hollensbe <github@hollensbe.org > (github: erikh)
2014-08-27 18:23:41 -07:00
Erik Hollensbe
925a3254e7
pkg/graphdb: tests for Parents and Children
...
Docker-DCO-1.1-Signed-off-by: Erik Hollensbe <github@hollensbe.org > (github: erikh)
2014-08-27 18:23:41 -07:00
Victor Vieux
450740c891
Update /etc/hosts when linked container is restarted
...
Docker-DCO-1.1-Signed-off-by: Victor Vieux <vieux@docker.com > (github: vieux)
2014-08-27 18:23:41 -07:00
SvenDowideit
8c6c4a12b7
add the [OPTIONS] string automatically if there are flags defined
...
Signed-off-by: SvenDowideit <SvenDowideit@home.org.au >
Docker-DCO-1.1-Signed-off-by: SvenDowideit <SvenDowideit@home.org.au > (github: SvenDowideit)
2014-08-28 08:50:50 +10:00
Victor Vieux
2e489073d9
Revert "--help option and help command should print to stdout not stderr"
...
This reverts commit 61b129d818 .
Signed-off-by: Victor Vieux <vieux@docker.com >
2014-08-27 18:59:13 +00:00
Dan Walsh
61b129d818
--help option and help command should print to stdout not stderr
...
--help and help are successful commands so output should not go to error.
QE teams have requested this change, also users doing docker help | less
or docker run --help | less would expect this to work.
Usage statement should only be printed when the user asks for it.
Errors should print error message and then suggest the docker COMMAND --help
command to see usage information.
The current behaviour causes the user to have to search for the error message
and sometimes scrolls right off the screen. For example a error on a
"docker run" command is very difficult to diagnose.
Finally erros should always exit with a non 0 exit code, if the user
makes a CLI error.
Docker-DCO-1.1-Signed-off-by: Dan Walsh <dwalsh@redhat.com > (github: rhatdan)
2014-08-21 15:35:20 -04:00
Eric Windisch
cd71f92a7f
Add Eric Windisch to MAINTAINER for tarsum
...
This code is vital to the security of the project and it is important
we assure it is well-maintained and guarded.
I am vested in assuring this code maintains security and
provides as much compatibility as possible between releases.
Signed-off-by: Eric Windisch <eric@windisch.us >
2014-08-20 11:19:46 -07:00
unclejack
55533693be
pkg/tarsum: avoid buf2 allocation in Read
...
Docker-DCO-1.1-Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com > (github: unclejack)
2014-08-17 14:45:11 +03:00
Erik Hollensbe
ac63d925d2
move utils.Fataler to pkg/log.Fataler
...
Docker-DCO-1.1-Signed-off-by: Erik Hollensbe <github@hollensbe.org > (github: erikh)
2014-08-13 15:32:41 -07:00
Josiah Kiehl
a02f67be5b
Extract log utils into pkg/log
...
Docker-DCO-1.1-Signed-off-by: Josiah Kiehl <josiah@capoferro.net > (github: capoferro)
2014-08-13 15:18:15 -07:00
Michael Crosby
cdf8a55670
Exit after receiving SIGTERM
...
Signed-off-by: Michael Crosby <michael@docker.com >
2014-08-13 12:18:23 -07:00
Alexandr Morozov
6cbb8e070d
Fix deadlock on failed dial in UDP userland proxy
...
Signed-off-by: Alexandr Morozov <lk4d4math@gmail.com >
2014-08-13 17:18:37 +04:00
lalyos
58ef92f89e
Fix equal short-long version number comparison
...
Signed-off-by: Lajos Papp <lajos.papp@sequenceiq.com >
2014-08-11 23:40:35 +02:00
lalyos
8a4d2d6f7f
Add test case for identical short and long version numbers
...
Signed-off-by: Lajos Papp <lajos.papp@sequenceiq.com >
2014-08-11 23:36:09 +02:00
Solomon Hykes
d55e3fea72
Move signal handling code to pkg/signal.Trap
...
Signed-off-by: Solomon Hykes <solomon@docker.com >
2014-08-06 17:56:11 +00:00
Michael Crosby
bc9f5cdeb5
Merge pull request #7329 from erikh/move_broadcastwriter
...
Cleanup: utils/broadcastwriter -> pkg/broadcastwriter
2014-08-07 14:51:42 -07:00
Michael Crosby
b386bce1f1
Graphtest is ok to compile normally
...
The graphtest package is only imported in the test files of other
packages therefore we do not leak testing flags.
Signed-off-by: Michael Crosby <michael@docker.com >
2014-08-07 14:33:09 -07:00
Peter Bourgon
b87daf6d69
Only import "testing" from *_test.go
...
This prevents the testing package flags from leaking into the flagsets
of binaries that import docker. I left integration-cli alone.
Docker-DCO-1.1-Signed-off-by: Peter Bourgon <peter@bourgon.org > (github: peterbourgon)
2014-08-07 14:25:21 -07:00
Erik Hollensbe
5cdb9c8aca
utils.Debugf -> log.Printf, move jsonlog to own package.
...
Docker-DCO-1.1-Signed-off-by: Erik Hollensbe <github@hollensbe.org > (github: erikh)
2014-08-06 16:39:01 -07:00
Erik Hollensbe
5ab09f2f71
utils/broadcastwriter -> pkg/broadcastwriter
...
Docker-DCO-1.1-Signed-off-by: Erik Hollensbe <github@hollensbe.org > (github: erikh)
2014-08-06 16:37:01 -07:00
Tianon Gravi
89ec17d113
Replace "amd64" build tags with "cgo" as appropriate, and remove where unnecessary
...
Signed-off-by: Andrew Page <admwiggin@gmail.com >
2014-08-06 17:20:21 -06:00
Tianon Gravi
60341f80d7
Purge the bits of pkg/system that moved to libcontainer/system
...
Signed-off-by: Andrew Page <admwiggin@gmail.com >
2014-08-02 01:35:04 -06:00
Michael Crosby
b1496effe3
Merge pull request #7312 from tianon/update-libcontainer
...
Bump libcontainer dep
2014-07-31 15:20:07 -07:00
Tibor Vass
531f5907d6
Merge pull request #7324 from erikh/move_tarsum
...
Move tarsum to pkg/
2014-07-31 16:56:24 -04:00
Tianon Gravi
f34d0e55f3
Remove pkg/user now that it's embedded in libcontainer
...
Docker-DCO-1.1-Signed-off-by: Andrew Page <admwiggin@gmail.com > (github: tianon)
2014-07-31 12:46:39 -06:00
Erik Hollensbe
ff02bea883
utils.Debugf -> fmt.Printf
...
Docker-DCO-1.1-Signed-off-by: Erik Hollensbe <github@hollensbe.org > (github: erikh)
2014-07-30 08:42:53 -07:00
Tibor Vass
b0fb0055d2
Add OS to docker info
...
Docker-DCO-1.1-Signed-off-by: Tibor Vass <teabee89@gmail.com > (github: tiborvass)
2014-07-30 10:37:52 -04:00