diff --git a/integration-cli/docker_api_build_test.go b/integration-cli/docker_api_build_test.go index 88f0631bcf..49de71c9af 100644 --- a/integration-cli/docker_api_build_test.go +++ b/integration-cli/docker_api_build_test.go @@ -4,8 +4,8 @@ import ( "archive/tar" "bytes" "net/http" - "strings" + "github.com/docker/docker/pkg/integration/checker" "github.com/go-check/check" ) @@ -17,31 +17,29 @@ func (s *DockerSuite) TestBuildApiDockerfilePath(c *check.C) { defer tw.Close() dockerfile := []byte("FROM busybox") - if err := tw.WriteHeader(&tar.Header{ + err := tw.WriteHeader(&tar.Header{ Name: "Dockerfile", Size: int64(len(dockerfile)), - }); err != nil { - c.Fatalf("failed to write tar file header: %v", err) - } - if _, err := tw.Write(dockerfile); err != nil { - c.Fatalf("failed to write tar file content: %v", err) - } - if err := tw.Close(); err != nil { - c.Fatalf("failed to close tar archive: %v", err) - } + }) + //failed to write tar file header + c.Assert(err, checker.IsNil) + + _, err = tw.Write(dockerfile) + // failed to write tar file content + c.Assert(err, checker.IsNil) + + // failed to close tar archive + c.Assert(tw.Close(), checker.IsNil) res, body, err := sockRequestRaw("POST", "/build?dockerfile=../Dockerfile", buffer, "application/x-tar") - c.Assert(err, check.IsNil) - c.Assert(res.StatusCode, check.Equals, http.StatusInternalServerError) + c.Assert(err, checker.IsNil) + c.Assert(res.StatusCode, checker.Equals, http.StatusInternalServerError) out, err := readBody(body) - if err != nil { - c.Fatal(err) - } + c.Assert(err, checker.IsNil) - if !strings.Contains(string(out), "Forbidden path outside the build context") { - c.Fatalf("Didn't complain about leaving build context: %s", out) - } + // Didn't complain about leaving build context + c.Assert(string(out), checker.Contains, "Forbidden path outside the build context") } func (s *DockerSuite) TestBuildApiDockerFileRemote(c *check.C) { @@ -53,27 +51,21 @@ COPY * /tmp/ RUN find / -name ba* RUN find /tmp/`, }) - if err != nil { - c.Fatal(err) - } + c.Assert(err, checker.IsNil) defer server.Close() res, body, err := sockRequestRaw("POST", "/build?dockerfile=baz&remote="+server.URL()+"/testD", nil, "application/json") - c.Assert(err, check.IsNil) - c.Assert(res.StatusCode, check.Equals, http.StatusOK) + c.Assert(err, checker.IsNil) + c.Assert(res.StatusCode, checker.Equals, http.StatusOK) buf, err := readBody(body) - if err != nil { - c.Fatal(err) - } + c.Assert(err, checker.IsNil) // Make sure Dockerfile exists. // Make sure 'baz' doesn't exist ANYWHERE despite being mentioned in the URL out := string(buf) - if !strings.Contains(out, "/tmp/Dockerfile") || - strings.Contains(out, "baz") { - c.Fatalf("Incorrect output: %s", out) - } + c.Assert(out, checker.Contains, "/tmp/Dockerfile") + c.Assert(out, checker.Not(checker.Contains), "baz") } func (s *DockerSuite) TestBuildApiRemoteTarballContext(c *check.C) { @@ -83,29 +75,30 @@ func (s *DockerSuite) TestBuildApiRemoteTarballContext(c *check.C) { defer tw.Close() dockerfile := []byte("FROM busybox") - if err := tw.WriteHeader(&tar.Header{ + err := tw.WriteHeader(&tar.Header{ Name: "Dockerfile", Size: int64(len(dockerfile)), - }); err != nil { - c.Fatalf("failed to write tar file header: %v", err) - } - if _, err := tw.Write(dockerfile); err != nil { - c.Fatalf("failed to write tar file content: %v", err) - } - if err := tw.Close(); err != nil { - c.Fatalf("failed to close tar archive: %v", err) - } + }) + // failed to write tar file header + c.Assert(err, checker.IsNil) + + _, err = tw.Write(dockerfile) + // failed to write tar file content + c.Assert(err, checker.IsNil) + + // failed to close tar archive + c.Assert(tw.Close(), checker.IsNil) server, err := fakeBinaryStorage(map[string]*bytes.Buffer{ "testT.tar": buffer, }) - c.Assert(err, check.IsNil) + c.Assert(err, checker.IsNil) defer server.Close() res, b, err := sockRequestRaw("POST", "/build?remote="+server.URL()+"/testT.tar", nil, "application/tar") - c.Assert(err, check.IsNil) - c.Assert(res.StatusCode, check.Equals, http.StatusOK) + c.Assert(err, checker.IsNil) + c.Assert(res.StatusCode, checker.Equals, http.StatusOK) b.Close() } @@ -117,51 +110,52 @@ func (s *DockerSuite) TestBuildApiRemoteTarballContextWithCustomDockerfile(c *ch dockerfile := []byte(`FROM busybox RUN echo 'wrong'`) - if err := tw.WriteHeader(&tar.Header{ + err := tw.WriteHeader(&tar.Header{ Name: "Dockerfile", Size: int64(len(dockerfile)), - }); err != nil { - c.Fatalf("failed to write tar file header: %v", err) - } - if _, err := tw.Write(dockerfile); err != nil { - c.Fatalf("failed to write tar file content: %v", err) - } + }) + // failed to write tar file header + c.Assert(err, checker.IsNil) + + _, err = tw.Write(dockerfile) + // failed to write tar file content + c.Assert(err, checker.IsNil) custom := []byte(`FROM busybox RUN echo 'right' `) - if err := tw.WriteHeader(&tar.Header{ + err = tw.WriteHeader(&tar.Header{ Name: "custom", Size: int64(len(custom)), - }); err != nil { - c.Fatalf("failed to write tar file header: %v", err) - } - if _, err := tw.Write(custom); err != nil { - c.Fatalf("failed to write tar file content: %v", err) - } + }) - if err := tw.Close(); err != nil { - c.Fatalf("failed to close tar archive: %v", err) - } + // failed to write tar file header + c.Assert(err, checker.IsNil) + + _, err = tw.Write(custom) + // failed to write tar file content + c.Assert(err, checker.IsNil) + + // failed to close tar archive + c.Assert(tw.Close(), checker.IsNil) server, err := fakeBinaryStorage(map[string]*bytes.Buffer{ "testT.tar": buffer, }) - c.Assert(err, check.IsNil) + c.Assert(err, checker.IsNil) defer server.Close() url := "/build?dockerfile=custom&remote=" + server.URL() + "/testT.tar" res, body, err := sockRequestRaw("POST", url, nil, "application/tar") - c.Assert(err, check.IsNil) - c.Assert(res.StatusCode, check.Equals, http.StatusOK) + c.Assert(err, checker.IsNil) + c.Assert(res.StatusCode, checker.Equals, http.StatusOK) defer body.Close() content, err := readBody(body) - c.Assert(err, check.IsNil) + c.Assert(err, checker.IsNil) - if strings.Contains(string(content), "wrong") { - c.Fatalf("Build used the wrong dockerfile.") - } + // Build used the wrong dockerfile. + c.Assert(string(content), checker.Not(checker.Contains), "wrong") } func (s *DockerSuite) TestBuildApiLowerDockerfile(c *check.C) { @@ -170,24 +164,18 @@ func (s *DockerSuite) TestBuildApiLowerDockerfile(c *check.C) { "dockerfile": `FROM busybox RUN echo from dockerfile`, }, false) - if err != nil { - c.Fatal(err) - } + c.Assert(err, checker.IsNil) defer git.Close() res, body, err := sockRequestRaw("POST", "/build?remote="+git.RepoURL, nil, "application/json") - c.Assert(err, check.IsNil) - c.Assert(res.StatusCode, check.Equals, http.StatusOK) + c.Assert(err, checker.IsNil) + c.Assert(res.StatusCode, checker.Equals, http.StatusOK) buf, err := readBody(body) - if err != nil { - c.Fatal(err) - } + c.Assert(err, checker.IsNil) out := string(buf) - if !strings.Contains(out, "from dockerfile") { - c.Fatalf("Incorrect output: %s", out) - } + c.Assert(out, checker.Contains, "from dockerfile") } func (s *DockerSuite) TestBuildApiBuildGitWithF(c *check.C) { @@ -198,25 +186,19 @@ RUN echo from baz`, "Dockerfile": `FROM busybox RUN echo from Dockerfile`, }, false) - if err != nil { - c.Fatal(err) - } + c.Assert(err, checker.IsNil) defer git.Close() // Make sure it tries to 'dockerfile' query param value res, body, err := sockRequestRaw("POST", "/build?dockerfile=baz&remote="+git.RepoURL, nil, "application/json") - c.Assert(err, check.IsNil) - c.Assert(res.StatusCode, check.Equals, http.StatusOK) + c.Assert(err, checker.IsNil) + c.Assert(res.StatusCode, checker.Equals, http.StatusOK) buf, err := readBody(body) - if err != nil { - c.Fatal(err) - } + c.Assert(err, checker.IsNil) out := string(buf) - if !strings.Contains(out, "from baz") { - c.Fatalf("Incorrect output: %s", out) - } + c.Assert(out, checker.Contains, "from baz") } func (s *DockerSuite) TestBuildApiDoubleDockerfile(c *check.C) { @@ -227,25 +209,19 @@ RUN echo from Dockerfile`, "dockerfile": `FROM busybox RUN echo from dockerfile`, }, false) - if err != nil { - c.Fatal(err) - } + c.Assert(err, checker.IsNil) defer git.Close() // Make sure it tries to 'dockerfile' query param value res, body, err := sockRequestRaw("POST", "/build?remote="+git.RepoURL, nil, "application/json") - c.Assert(err, check.IsNil) - c.Assert(res.StatusCode, check.Equals, http.StatusOK) + c.Assert(err, checker.IsNil) + c.Assert(res.StatusCode, checker.Equals, http.StatusOK) buf, err := readBody(body) - if err != nil { - c.Fatal(err) - } + c.Assert(err, checker.IsNil) out := string(buf) - if !strings.Contains(out, "from Dockerfile") { - c.Fatalf("Incorrect output: %s", out) - } + c.Assert(out, checker.Contains, "from Dockerfile") } func (s *DockerSuite) TestBuildApiDockerfileSymlink(c *check.C) { @@ -255,31 +231,27 @@ func (s *DockerSuite) TestBuildApiDockerfileSymlink(c *check.C) { tw := tar.NewWriter(buffer) defer tw.Close() - if err := tw.WriteHeader(&tar.Header{ + err := tw.WriteHeader(&tar.Header{ Name: "Dockerfile", Typeflag: tar.TypeSymlink, Linkname: "/etc/passwd", - }); err != nil { - c.Fatalf("failed to write tar file header: %v", err) - } - if err := tw.Close(); err != nil { - c.Fatalf("failed to close tar archive: %v", err) - } + }) + // failed to write tar file header + c.Assert(err, checker.IsNil) + + // failed to close tar archive + c.Assert(tw.Close(), checker.IsNil) res, body, err := sockRequestRaw("POST", "/build", buffer, "application/x-tar") - c.Assert(err, check.IsNil) - c.Assert(res.StatusCode, check.Equals, http.StatusInternalServerError) + c.Assert(err, checker.IsNil) + c.Assert(res.StatusCode, checker.Equals, http.StatusInternalServerError) out, err := readBody(body) - if err != nil { - c.Fatal(err) - } + c.Assert(err, checker.IsNil) // The reason the error is "Cannot locate specified Dockerfile" is because // in the builder, the symlink is resolved within the context, therefore // Dockerfile -> /etc/passwd becomes etc/passwd from the context which is // a nonexistent file. - if !strings.Contains(string(out), "Cannot locate specified Dockerfile: Dockerfile") { - c.Fatalf("Didn't complain about leaving build context: %s", out) - } + c.Assert(string(out), checker.Contains, "Cannot locate specified Dockerfile: Dockerfile", check.Commentf("Didn't complain about leaving build context")) }