From 6bb5a82e6505d5d3243bde86e0f2e40e21e8a233 Mon Sep 17 00:00:00 2001 From: Ian Stanion Date: Tue, 20 Jun 2023 04:19:30 -0400 Subject: [PATCH] Changes based on review --- .../webNavigation/basic/{webNavigation.md => README.md} | 2 +- api-samples/webNavigation/basic/service-worker.js | 9 +++++++-- 2 files changed, 8 insertions(+), 3 deletions(-) rename api-samples/webNavigation/basic/{webNavigation.md => README.md} (95%) diff --git a/api-samples/webNavigation/basic/webNavigation.md b/api-samples/webNavigation/basic/README.md similarity index 95% rename from api-samples/webNavigation/basic/webNavigation.md rename to api-samples/webNavigation/basic/README.md index db832162..b45e6078 100644 --- a/api-samples/webNavigation/basic/webNavigation.md +++ b/api-samples/webNavigation/basic/README.md @@ -1,4 +1,4 @@ -# Title +# chrome.webNavigation This sample demonstrates using the webNavigation API to send notifications. diff --git a/api-samples/webNavigation/basic/service-worker.js b/api-samples/webNavigation/basic/service-worker.js index eeb783f8..e7b142e5 100644 --- a/api-samples/webNavigation/basic/service-worker.js +++ b/api-samples/webNavigation/basic/service-worker.js @@ -12,11 +12,16 @@ // See the License for the specific language governing permissions and // limitations under the License. -chrome.webNavigation.onCompleted.addListener(() => { +chrome.webNavigation.onCompleted.addListener((details) => { chrome.notifications.create({ type: 'basic', iconUrl: 'icon.png', title: 'page loaded', - message: 'Page has completed loading' + message: + 'Completed loading: ' + + details.url + + ' at ' + + details.timeStamp + + ' milliseconds since the epoch.' }); });