From 08e8c96c5f6d291ebb1770d1031a1999c14a6c95 Mon Sep 17 00:00:00 2001 From: Oliver Dunk Date: Mon, 2 Jun 2025 12:46:10 +0100 Subject: [PATCH] Add linter fixes for new AI samples (#1484) --- eslint.config.js | 1 + .../ai.gemini-on-device-alt-texter/background.js | 2 +- .../ai.gemini-on-device-audio-scribe/demo-chat-app/script.js | 1 - .../ai.gemini-on-device-audio-scribe/sidepanel.js | 5 ++--- 4 files changed, 4 insertions(+), 5 deletions(-) diff --git a/eslint.config.js b/eslint.config.js index 8fa2b55f..1b44b0b0 100644 --- a/eslint.config.js +++ b/eslint.config.js @@ -65,6 +65,7 @@ module.exports = [ '_archive/**/*', '**/third-party/**', '**/node_modules/**/*', + '**/dist/**/*', // These are autogenerated files that we shouldn't lint 'functional-samples/cookbook.wasm-helloworld-print/wasm/pkg/**/*', 'functional-samples/cookbook.wasm-helloworld-print-nomodule/wasm/pkg/**/*' diff --git a/functional-samples/ai.gemini-on-device-alt-texter/background.js b/functional-samples/ai.gemini-on-device-alt-texter/background.js index f427e562..5176799f 100644 --- a/functional-samples/ai.gemini-on-device-alt-texter/background.js +++ b/functional-samples/ai.gemini-on-device-alt-texter/background.js @@ -26,7 +26,7 @@ async function generateAltText(imgSrc) { return await session.prompt(prompt); } -chrome.contextMenus.onClicked.addListener(async (info, tab) => { +chrome.contextMenus.onClicked.addListener(async (info, _tab) => { if (info.menuItemId === 'generateAltText' && info.srcUrl) { // Start opening the popup const [result] = await Promise.allSettled([ diff --git a/functional-samples/ai.gemini-on-device-audio-scribe/demo-chat-app/script.js b/functional-samples/ai.gemini-on-device-audio-scribe/demo-chat-app/script.js index ca1888a4..40a3e18a 100644 --- a/functional-samples/ai.gemini-on-device-audio-scribe/demo-chat-app/script.js +++ b/functional-samples/ai.gemini-on-device-audio-scribe/demo-chat-app/script.js @@ -10,7 +10,6 @@ document.addEventListener('DOMContentLoaded', () => { async function renderMessages() { messageList.innerHTML = ''; // Clear existing messages - let delay = 0; // Initial delay const delayIncrement = 3000; // 5 seconds in milliseconds await timeout(3000); diff --git a/functional-samples/ai.gemini-on-device-audio-scribe/sidepanel.js b/functional-samples/ai.gemini-on-device-audio-scribe/sidepanel.js index 60118c00..c3ab942e 100644 --- a/functional-samples/ai.gemini-on-device-audio-scribe/sidepanel.js +++ b/functional-samples/ai.gemini-on-device-audio-scribe/sidepanel.js @@ -67,11 +67,10 @@ chrome.runtime.onMessage.addListener(async ({ data }) => { }); function isValidUrl(string) { - let url; - try { - url = new URL(string); + new URL(string); return true; + // eslint-disable-next-line no-unused-vars } catch (_) { return false; }